Kitely Forums

I'm scripting a gun turret and need it to distinguish NPCs from avatars. Currently using the llGetAgentList function, but that doesn't seem to be able to tell the difference. Is there an OSSL function that works better?

Hi Mike,

You can see the list of supported NPC-related functions here: https://www.kitely.com/virtual-world-ne ... functions/

The OpenSimWorld NPC toolkit creates NPCs with (NPC) as the last name/suffix. That makes it pretty easy to identify them.

Okay, I may be screwing this up but I don't think so. Here's a snippet of my threat detection list code at present.

<php>
timer()
{
list keys = llGetAgentList(AGENT_LIST_REGION, []);
integer numberOfKeys = llGetListLength(keys);

vector currentPos = llGetPos();
list newkeys;
key thisAvKey;

integer i;
for (i = 0; i < numberOfKeys; ++i) {
thisAvKey = llList2Key(keys,i);
integer isNPC = osIsNpc(thisAvKey);
if (isNPC == FALSE)
{

newkeys += [llRound(llVecDist(currentPos,
llList2Vector(llGetObjectDetails(thisAvKey, [OBJECT_POS]), 0))),
thisAvKey];
}
llDeleteSubList(keys,i,i);
numberOfKeys = llGetListLength(keys);
}

newkeys = llListSort(newkeys, 2, FALSE); // sort strided list by descending distance

for (i = 0; i < (numberOfKeys * 2); i += 2) {
llOwnerSay(llGetDisplayName(llList2Key(newkeys, i+1))
+" ["+ (string) llList2Integer(newkeys, i) + "m]");
}
}
</php>

It is throwing up the following output:

[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]
[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]
[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]
[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]
[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]

So it looks like its removing the NPC's name from the list, but is still reporting on that as an entry in the list... I'd like to have it remove it entirely, but not exactly sure whats wrong. List management is not my forte in SL/OS scripting yet.

Mike Lorrey wrote:Okay, I may be screwing this up but I don't think so. Here's a snippet of my threat detection list code at present.

Code: Select all

        integer numberOfKeys = llGetListLength(keys);
        ...
        for (i = 0; i < (numberOfKeys * 2); i += 2) {
        llOwnerSay(llGetDisplayName(llList2Key(newkeys, i+1))
              +" ["+ (string) llList2Integer(newkeys, i) + "m]");
        }

It is throwing up the following output:

[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]

So it looks like its removing the NPC's name from the list, but is still reporting on that as an entry in the list... I'd like to have it remove it entirely, but not exactly sure whats wrong. List management is not my forte in SL/OS scripting yet.

(int) numberOfKeys was based on the length of "keys" but your list of "newkeys" is only a subset of "keys" - despite you popping in a distance measurement as your so called strided array. so it appears your newkeys is fine, but your loop condition is based on the larger sized array "keys" so it's overshooting. when you print from memory that is outside of your "newkeys" array it just prints a zero length string or the number zero etc. which is why you get that second line. i think your output log was just repeating this pair of lines over and over, so i'm guessing you had just yourself as 1x non-NPC and then 1x NPC only (but im not sure )

PS. i was going to say sometimes it's easier to spot this when the memory values are something funny you get weird strings... then i got carried away mashing random alt+numpad values lol...

Man I cant believe I didn't see that on the wiki, ive been using osNpcGetPos to validate npcs!

Thanks for the snippet!

skindup truk wrote:

Mike Lorrey wrote:Okay, I may be screwing this up but I don't think so. Here's a snippet of my threat detection list code at present.

Code: Select all

        integer numberOfKeys = llGetListLength(keys);
        ...
        for (i = 0; i < (numberOfKeys * 2); i += 2) {
        llOwnerSay(llGetDisplayName(llList2Key(newkeys, i+1))
              +" ["+ (string) llList2Integer(newkeys, i) + "m]");
        }

It is throwing up the following output:

[09:12] Laser Turret - 2bbl- Ball: Mike Lorrey [6m]
[09:12] Laser Turret - 2bbl- Ball: [0m]

So it looks like its removing the NPC's name from the list, but is still reporting on that as an entry in the list... I'd like to have it remove it entirely, but not exactly sure whats wrong. List management is not my forte in SL/OS scripting yet.

(int) numberOfKeys was based on the length of "keys" but your list of "newkeys" is only a subset of "keys" - despite you popping in a distance measurement as your so called strided array. so it appears your newkeys is fine, but your loop condition is based on the larger sized array "keys" so it's overshooting. when you print from memory that is outside of your "newkeys" array it just prints a zero length string or the number zero etc. which is why you get that second line. i think your output log was just repeating this pair of lines over and over, so i'm guessing you had just yourself as 1x non-NPC and then 1x NPC only (but im not sure )

the second line is detecting my NPC cat, actually. I got it to remove the cats name from the list, but its still reporting it as a detected av. Like I said, I'm not great with lists in LSL, so I'd appreciate some feedback on fixing that code.

i have been away for awhile...! did u ever fix this?

The following seems to work as expected: